chromeos: Silence log spam from x11_util.cc.

chromeos: Silence log spam from x11_util.cc.

The log spam happens when running browser_tests on Chrome OS, or running
Chrome for Chrome OS on Linux desktop.

The source of the spam was XGrabKey in
chrome/browser/chromeos/system_key_event_listener.cc.

We should use this class only when Chrome is running on Chrome OS in
non-test mode.

TEST=the log spam is gone from linux desktop, and function keys work on Chrome OS as before.
BUG=chromium-os:21331
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106994

[Daniel Erat, 2011-10-24 19:58:23]

lgtm

[stevenjb, 2011-10-24 20:17:36]

Thanks for doing this!
lgtm with nit

http://codereview.chromium.org/8380011/diff/1001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/8380011/diff/1001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:2049: !parameters().ui_task) {
nit: SystemKeyEventListener::Shutdown() is always safe to call; I feel that
mirrored logic like this is risky to maintain and would rather always call
Shutdown() (e.g. if we change when we call Initialize() and forgot to change
this logic we might introduce a leak, bug, or crash on shutdown)

[satorux1, 2011-10-24 20:27:28]

http://codereview.chromium.org/8380011/diff/1001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/8380011/diff/1001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:2049: !parameters().ui_task) {
On 2011/10/24 20:17:36, Steven Bennetts wrote:
> nit: SystemKeyEventListener::Shutdown() is always safe to call; I feel that
> mirrored logic like this is risky to maintain and would rather always call
> Shutdown() (e.g. if we change when we call Initialize() and forgot to change
> this logic we might introduce a leak, bug, or crash on shutdown)

Agreed. Removed the conditional and added some comment about it.