Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8380009: Merge 98243 - Web Inspector: [Styles] Adding a new style rule breaks things (Closed)

Created:
9 years, 2 months ago by apavlov
Modified:
9 years, 2 months ago
Reviewers:
apavlov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 98243 - Web Inspector: [Styles] Adding a new style rule breaks things https://bugs.webkit.org/show_bug.cgi?id=70721 Reviewed by Pavel Feldman. Source/WebCore: We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack, but still had dependencies on the old behavior. * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace): (WebInspector.BlankStylePropertiesSection.prototype.get isBlank): (WebInspector.BlankStylePropertiesSection.prototype.expand): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): LayoutTests: * inspector/styles/styles-add-new-rule-expected.txt: * inspector/styles/styles-add-new-rule.html: TBR=apavlov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M LayoutTests/inspector/styles/styles-add-new-rule.html View 2 chunks +24 lines, -9 lines 0 comments Download
M LayoutTests/inspector/styles/styles-add-new-rule-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/StylesSidebarPane.js View 6 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
apavlov
9 years, 2 months ago (2011-10-24 16:27:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698