Suppress a conditional jump depending on uninit value in SendExtensionWebRequestStatusToHost (iss...

Suppress a conditional jump depending on uninit value in SendExtensionWebRequestStatusToHost (issue 101335)
Add a new stack for issue 101146
Suppress an UninitCondition in RenderViewImpl::SyncSelectionIfRequired (issue 101342)

BUG=101335, 101146, 101342
TBR=oshima
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106904

[Alexander Potapenko, 2011-10-24 10:53:26]

TBR

[oshima, 2011-10-24 16:22:15]

LGTM

On Mon, Oct 24, 2011 at 3:53 AM, <glider@chromium.org> wrote:

> Reviewers: oshima,
>
> Message:
> TBR
>
> Description:
> Suppress a conditional jump depending on uninit value in
> SendExtensionWebRequestStatusT**oHost (issue 101335)
> Add a new stack for issue 101146
> Suppress an UninitCondition in RenderViewImpl::**SyncSelectionIfRequired
> (issue
> 101342)
>
> BUG=101335,101146,101342
> TBR=oshima
> Committed: http://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=106904<http://src.chromium.org/viewvc/chrome?view=rev&revision=106904>
>
> Please review this at
http://codereview.chromium.**org/8380001/<http://codereview.chromium.org/8380...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     tools/valgrind/memcheck/**suppressions.txt
>
>
> Index: tools/valgrind/memcheck/**suppressions.txt
> ==============================**==============================**=======
> --- tools/valgrind/memcheck/**suppressions.txt    (revision 106896)
> +++ tools/valgrind/memcheck/**suppressions.txt    (working copy)
> @@ -4908,6 +4908,20 @@
>    fun:_**ZN7WebCore14ResourceHandle5sta**rtEPNS_17NetworkingContextE
>  }
>  {
> +   bug_101146c
> +   Memcheck:Leak
> +   fun:_Znw*
> +   fun:_ZN11webkit_**glue16WebURLLoaderImplC1Ev
> +   fun:_ZN11webkit_**glue25WebKitPlatformSupportImp**l15createURLLoaderEv
> +   fun:_ZN11webkit_**glue15ResourceFetcher5StartEPN**6WebKit8WebFrameE
> +   fun:_ZN11webkit_**glue15ResourceFetcherC2ERK4GUR**
> LPN6WebKit8WebFrameENS4_**13WebURLRequest10TargetTypeEP1**
> 4CallbackRunnerI6Tuple2IRKNS4_**14WebURLResponseERKSsEE
> +   fun:_ZN11webkit_**glue26ResourceFetcherWithTimeo**
> utC1ERK4GURLPN6WebKit8WebFrame**ENS4_**13WebURLRequest10TargetTypeEiP**
> 14CallbackRunnerI6Tuple2IRKNS4**_14WebURLResponseERKSsEE
> +   fun:_ZN11webkit_**glue27AltErrorPageResourceFetc**
> herC1ERK4GURLPN6WebKit8WebFram**eERKNS4_**11WebURLErrorEP14CallbackRunne**
> rI6Tuple3IS6_S9_RKSsEE
> +   fun:_**ZN14RenderViewImpl27MaybeLoadA**lternateErrorPageEPN6WebKit8We*
> *bFrameERKNS0_11WebURLErrorEb
> +   fun:_**ZN14RenderViewImpl22didFailPro**visionalLoadEPN6WebKit8WebFram*
> *eERKNS0_11WebURLErrorE
> +   fun:_**ZN6WebKit12WebFrameImpl7didFai**lERKN7WebCore13ResourceErrorEb
> +}
> +{
>    bug_101151
>    Memcheck:Leak
>    fun:_Znw*
> @@ -4930,7 +4944,42 @@
>    fun:_**ZN6webkit5npapi13WebPluginImpl**23GetWindowScriptNPObjectEv
>    fun:NPN_GetValue
>  }
> +{
> +   bug_101335
> +   Memcheck:Cond
> +   fun:_**Z35SendExtensionWebRequestStat**usToHostP17RenderProcessHost
> +   fun:_**ZN6chrome26ChromeContentBrowse**rClient31BrowserRenderProcessH*
> *ostCreatedEP24BrowserRenderPro**cessHost
> +   fun:_**ZN24BrowserRenderProcessHost4I**nitEb
> +   fun:_**ZN14RenderViewHost16CreateRend**erViewERKSbItN4base20string16_*
> *char_traitsESaItEE
> +   fun:_**ZN11TabContents32CreateRenderV**iewForRenderManagerEP14RenderV*
> *iewHost
> +   ...
> +   fun:_**ZN21RenderViewHostManager14Ini**tRenderViewEP14RenderViewHostR*
> *K15NavigationEntry
> +   fun:_**ZN21RenderViewHostManager8Navi**gateERK15NavigationEntry
> +   fun:_**ZN11TabContents15NavigateToEnt**ryERK15NavigationEntryN20Navig*
> *ationController10ReloadTypeE
> +   fun:_**ZN11TabContents22NavigateToPen**dingEntryEN20NavigationControl*
> *ler10ReloadTypeE
> +   fun:_**ZN20NavigationController22Navi**gateToPendingEntryENS_**
> 10ReloadTypeE
> +   fun:_**ZN20NavigationController9LoadE**ntryEP15NavigationEntry
> +   fun:_**ZN20NavigationController7LoadU**RLERK4GURLS2_**
> N7content14PageTransitionERKSs
> +   fun:_ZN7browser8NavigateEPNS_**14NavigateParamsE
> +}
> +{
> +   bug_101342
> +   Memcheck:Cond
> +   fun:_**ZN14RenderViewImpl23SyncSelect**ionIfRequiredEv
> +   fun:_**ZN14RenderViewImpl18didChangeS**electionEb
> +   fun:_**ZN6WebKit16EditorClientImpl25r**espondToChangedSelectionEv
> +   fun:_**ZN7WebCore6Editor25respondToCh**angedSelectionERKNS_**
> 16VisibleSelectionE
> +   fun:_**ZN7WebCore6Editor25respondToCh**angedSelectionERKNS_**
> 16VisibleSelectionEj
> +   fun:_**ZN7WebCore14FrameSelection12se**tSelectionERKNS_**
> 16VisibleSelectionEjNS0_**19CursorAlignOnScrollENS_**15TextGranularityE
> +   fun:_**ZN7WebCore14FrameSelection12se**tSelectionERKNS_**
> 16VisibleSelectionENS_**15TextGranularityE
> +   fun:_**ZN7WebCore14FrameSelection34se**tNonDirectionalSelectionIfNeed*
> *edERKNS_16VisibleSelectionENS_**15TextGranularityENS0_**
> 23EndPointsAdjustmentModeE
> +   fun:_**ZN7WebCore12EventHandler49upda**teSelectionForMouseDownDispatc*
> *hingSelectStartEPNS_**4NodeERKNS_**16VisibleSelectionENS_**
> 15TextGranularityE
> +   fun:_**ZN7WebCore12EventHandler32hand**leMousePressEventSingleClickER*
> *KNS_**28MouseEventWithHitTestResults**E
> +   fun:_**ZN7WebCore12EventHandler21hand**leMousePressEventERKNS_**
> 28MouseEventWithHitTestResults**E
> +   fun:_**ZN7WebCore12EventHandler21hand**leMousePressEventERKNS_**
> 18PlatformMouseEventE
> +}
>
> +
>  #-----------------------------**------------------------------**
> ------------
>  # 4. These only occur on our Google workstations
>  {
>
>
>