Implementing custom notification icons for the DisplayBalloon method on Windows.

Implementing custom notification icons for the DisplayBalloon method on Windows.

This patch also fixes a problem with the notification balloons for Windows XP and a persisting tray icon problem in Windows 7.

BUG=74970
TEST=install background app on window, see balloon near status tray icon.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107454

[Leandro Graciá Gil, 2011-10-24 15:19:30]

To be landed after issue 8351004. Trying the full change with the bots in the
first patch uploaded.

[Andrew T Wilson (Slow), 2011-10-26 01:05:01]

LGTM, with one nit below.

http://codereview.chromium.org/8379003/diff/4001/chrome/browser/ui/views/stat...
File chrome/browser/ui/views/status_icons/status_icon_win.h (right):

http://codereview.chromium.org/8379003/diff/4001/chrome/browser/ui/views/stat...
chrome/browser/ui/views/status_icons/status_icon_win.h:48: void HideBalloon();
Not sure that this should be public?

[Leandro Graciá Gil, 2011-10-26 12:13:26]

I've detected an additional problem that appeared when you generated many
notification balloons: some of the icons weren't properly removed until the app
shut down. The cause was not properly initializing the NOTIFYICONDATA structure
to zero before setting any attributes, therefore carrying flags from previous
calls that shouldn't be there.

This affected the code before this patch and should be fixed with it.
Additionally, the HideBalloon code isn't required anymore as with the proper
initialization the balloon correctly disappears when removing the icon.

http://codereview.chromium.org/8379003/diff/4001/chrome/browser/ui/views/stat...
File chrome/browser/ui/views/status_icons/status_icon_win.h (right):

http://codereview.chromium.org/8379003/diff/4001/chrome/browser/ui/views/stat...
chrome/browser/ui/views/status_icons/status_icon_win.h:48: void HideBalloon();
Addressed in the next patch.

On 2011/10/26 01:05:01, Andrew T Wilson wrote:
> Not sure that this should be public?

[Andrew T Wilson (Slow), 2011-10-26 22:28:03]

lgtm