Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: runtime/lib/string.dart

Issue 8379001: Implement String.contains when the pattern is not a string. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string.dart
===================================================================
--- runtime/lib/string.dart (revision 626)
+++ runtime/lib/string.dart (working copy)
@@ -180,10 +180,10 @@
}
bool contains(Pattern other, int startIndex) {
- if (other is RegExp) {
- throw "Unimplemented String.contains with RegExp";
+ if (other is String) {
+ return indexOf(other, startIndex) >= 0;
}
- return indexOf(other, startIndex) >= 0;
+ return other.allMatches(this.substring(startIndex)).iterator().hasNext();
}
String replaceFirst(Pattern from, String to) {
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698