Issue 8378001: MIPS: port Avoid static initializers in assember-arm.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8378001: MIPS: port Avoid static initializers in assember-arm.h. (Closed)

Created:
9 years, 2 months ago by Paul Lind

Modified:
9 years, 1 month ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

MIPS: port Avoid static initializers in assember-arm.h. Port r9732 (30ceb2e) BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9781

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/mips/assembler-mips.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

Hi Florian - just a mips followup to the patch you submitted Friday from joth@chromium.org.

9 years, 2 months ago (2011-10-24 04:32:51 UTC) #1

fschneider

9 years, 1 month ago (2011-10-26 08:01:56 UTC) #2

http://codereview.chromium.org/8378001/diff/1/src/mips/assembler-mips.h
File src/mips/assembler-mips.h (right):

http://codereview.chromium.org/8378001/diff/1/src/mips/assembler-mips.h#newco...
src/mips/assembler-mips.h:305: static const FPURegister kDoubleRegZero = f28;
This should be a const-reference tp avoid the static initializer:

static const FPURegister&

I'll fix it and land.

Expand Messages | Collapse Messages