aura: Add touch-event support for RWHVA.

aura: Add touch-event support for RWHVA.

The way a WebTouchEvent is prepared in RWHVAura is the same as it is in
RWHVViews: the RWHVA maintains a WebTouchEvent, and each aura::TouchEvent
adds/removes/updates a WebTouchPoint in the WTE.

BUG=99757
TEST=manually, with the --touch-devices flag on linux.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107569

[Ben Goodger (Google), 2011-10-25 15:00:30]

http://codereview.chromium.org/8377001/diff/3001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/8377001/diff/3001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:397:
WebKit::WebTouchPoint* point = NULL;
Can we do this in a separate factory function a la the other events?

This function is pretty gigantic.

[sadrul, 2011-10-25 15:09:45]

http://codereview.chromium.org/8377001/diff/3001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/8377001/diff/3001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:397:
WebKit::WebTouchPoint* point = NULL;
On 2011/10/25 15:00:30, Ben Goodger (Google) wrote:
> Can we do this in a separate factory function a la the other events?
> 
> This function is pretty gigantic.

I was going to do this like the other functions, but it's a bit tricky: there
are some processing after the touch event is forwarded to the renderer (line 474
onward). Should this be done in two steps like this:

  WebKit::WebTouchPoint* point = content::UpdateWebTouchEvent(event,
touch_event_);
  host_->ForwardTouchEvent(touch_event_);
  if (event->type() == ui::ET_TOUCH_RELEASED) {
    RemoveTouchPoint(&touch_event_, point);
    status = ...
  } else {
    status = ...
  }
  return status;

[Ben Goodger (Google), 2011-10-25 15:23:04]

Looks good, but I'd put both pre- and post- processing in their own functions
and label them such.

[sadrul, 2011-10-25 19:09:55]

http://codereview.chromium.org/8377001/diff/8003/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/8377001/diff/8003/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:62: if
(point->state != WebKit::WebTouchPoint::StateReleased)
I kept this here, and didn't move to content:: since the code should be the same
on both windows and linux.

[Ben Goodger (Google), 2011-10-26 17:19:24]

lgtm