Issue 8375053: Handlify CompileLoadGlobal, CompileLoadElement, CompileLoadPolymorphic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8375053: Handlify CompileLoadGlobal, CompileLoadElement, CompileLoadPolymorphic. (Closed)

Created:
9 years, 1 month ago by ulan

Modified:
9 years, 1 month ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Handlify CompileLoadGlobal, CompileLoadElement, CompileLoadPolymorphic. R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9788

Patch Set 1 #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -121 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	7 chunks	+22 lines, -23 lines	2 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	6 chunks	+24 lines, -23 lines	1 comment	Download
M	src/stub-cache.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	src/stub-cache.cc	View	3 chunks	+0 lines, -39 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	6 chunks	+22 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 1 month ago (2011-10-26 08:43:41 UTC) #2

LGTM.

http://codereview.chromium.org/8375053/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8375053/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:3372: __ DispatchMap(r1,
This probably fits all on one line, if you like that sort of thing.

http://codereview.chromium.org/8375053/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:3382: return GetCode(NORMAL,
factory()->empty_string());
I think this is OK (changing from NULL String* to a handle to the empty string)
because the name is used for logging and disassembly.

http://codereview.chromium.org/8375053/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/8375053/diff/1/src/ia32/stub-cache-ia32.cc#new...
src/ia32/stub-cache-ia32.cc:3409: __ DispatchMap(edx,
Again, fits on one line.

Expand Messages | Collapse Messages