Separate the syncing of extension settings and app settings into separate data

chrome/browser/extensions/extension_settings_backend.h

Index: chrome/browser/extensions/extension_settings_backend.h
diff --git a/chrome/browser/extensions/extension_settings_backend.h b/chrome/browser/extensions/extension_settings_backend.h
index 81c1067f580600f1e2875953228839efdee46306..3f146227ce0db8efd6fce703a804f88636a2ceae 100644
--- a/chrome/browser/extensions/extension_settings_backend.h
+++ b/chrome/browser/extensions/extension_settings_backend.h
@@ -26,7 +26,7 @@ class ExtensionSettingsBackend : public SyncableService {
   // |observers| is the list of observers to settings changes.
   explicit ExtensionSettingsBackend(
       const FilePath& base_path,
-      const scoped_refptr<ObserverListThreadSafe<ExtensionSettingsObserver> >&
+      const scoped_refptr<ExtensionSettingsObserverList >&
           observers);
 
   virtual ~ExtensionSettingsBackend();
@@ -41,7 +41,7 @@ class ExtensionSettingsBackend : public SyncableService {
       const std::string& extension_id) const;
 
   // Deletes all setting data for an extension.  Call on the FILE thread.
-  void DeleteExtensionData(const std::string& extension_id);
+  void DeleteStorage(const std::string& extension_id);
 
   // Sends a change event to the observer list.  |profile| is the profile which
   // generated the change.  Must be called on the FILE thread.
@@ -78,8 +78,7 @@ class ExtensionSettingsBackend : public SyncableService {
   const FilePath base_path_;
 
   // The list of observers to settings changes.
-  const scoped_refptr<ObserverListThreadSafe<ExtensionSettingsObserver> >
-      observers_;
+  const scoped_refptr<ExtensionSettingsObserverList> observers_;
 
   // A cache of ExtensionSettingsStorage objects that have already been created.
   // Ensure that there is only ever one created per extension.
@@ -87,6 +86,10 @@ class ExtensionSettingsBackend : public SyncableService {
       StorageObjMap;
   mutable StorageObjMap storage_objs_;
 
+  // Current sync model type.  Will be UNSPECIFIED if sync hasn't been enabled
+  // yet, and either EXTENSION_SETTINGS or APP_SETTINGS if it has been.
+  syncable::ModelType sync_type_;
+
   // Current sync processor, if any.
   SyncChangeProcessor* sync_processor_;