Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: chrome/browser/extensions/extension_settings_api.h

Issue 8375047: Separate the syncing of extension settings and app settings into separate data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_settings_api.h
diff --git a/chrome/browser/extensions/extension_settings_api.h b/chrome/browser/extensions/extension_settings_api.h
index 15f3fcb867bb10d89af4fd02e1de87bd2c5c50ca..97d559bf41a92884820ab326e186f68c7da63da4 100644
--- a/chrome/browser/extensions/extension_settings_api.h
+++ b/chrome/browser/extensions/extension_settings_api.h
@@ -22,19 +22,21 @@ class SettingsFunction : public AsyncExtensionFunction {
// Implementations should fill in args themselves, though (like RunImpl)
// may return false to imply failure.
virtual bool RunWithStorage(
- ExtensionSettingsBackend* backend,
+ ExtensionSettingsObserverList* observers,
ExtensionSettingsStorage* storage) = 0;
// Sets error_ or result_ depending on the value of a storage Result, and
// returns whether the Result implies success (i.e. !error).
bool UseResult(
- ExtensionSettingsBackend* backend,
+ ExtensionSettingsObserverList* observers,
const ExtensionSettingsStorage::Result& storage_result);
private:
// Called via PostTask from RunImpl. Calls RunWithStorage and then
// SendReponse with its success value.
- void RunWithBackendOnFileThread(ExtensionSettingsBackend* backend);
+ void RunWithStorageOnFileThread(
+ scoped_refptr<ExtensionSettingsObserverList> observers,
+ ExtensionSettingsStorage* storage);
};
class GetSettingsFunction : public SettingsFunction {
@@ -43,7 +45,7 @@ class GetSettingsFunction : public SettingsFunction {
protected:
virtual bool RunWithStorage(
- ExtensionSettingsBackend* backend,
+ ExtensionSettingsObserverList* observers,
ExtensionSettingsStorage* storage) OVERRIDE;
};
@@ -53,7 +55,7 @@ class SetSettingsFunction : public SettingsFunction {
protected:
virtual bool RunWithStorage(
- ExtensionSettingsBackend* backend,
+ ExtensionSettingsObserverList* observers,
ExtensionSettingsStorage* storage) OVERRIDE;
};
@@ -63,7 +65,7 @@ class RemoveSettingsFunction : public SettingsFunction {
protected:
virtual bool RunWithStorage(
- ExtensionSettingsBackend* backend,
+ ExtensionSettingsObserverList* observers,
ExtensionSettingsStorage* storage) OVERRIDE;
};
@@ -73,7 +75,7 @@ class ClearSettingsFunction : public SettingsFunction {
protected:
virtual bool RunWithStorage(
- ExtensionSettingsBackend* backend,
+ ExtensionSettingsObserverList* observers,
ExtensionSettingsStorage* storage) OVERRIDE;
};

Powered by Google App Engine
This is Rietveld 408576698