Separate the syncing of extension settings and app settings into separate data

chrome/browser/extensions/extension_settings_api.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_API_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 #include "chrome/browser/extensions/extension_function.h"
 #include "chrome/browser/extensions/extension_settings_backend.h"
 #include "chrome/browser/extensions/extension_settings_storage.h"
 
 // Superclass of all settings functions.
 class SettingsFunction : public AsyncExtensionFunction {
  protected:
   virtual bool RunImpl() OVERRIDE;
 
   // Extension settings function implementations should do their work here.
   // This runs on the FILE thread.
   //
   // Implementations should fill in args themselves, though (like RunImpl)
   // may return false to imply failure.
   virtual bool RunWithStorage(
-      ExtensionSettingsBackend* backend,
+      ExtensionSettingsObserverList* observers,
       ExtensionSettingsStorage* storage) = 0;
 
   // Sets error_ or result_ depending on the value of a storage Result, and
   // returns whether the Result implies success (i.e. !error).
   bool UseResult(
-      ExtensionSettingsBackend* backend,
+      ExtensionSettingsObserverList* observers,
       const ExtensionSettingsStorage::Result& storage_result);
 
  private:
   // Called via PostTask from RunImpl.  Calls RunWithStorage and then
   // SendReponse with its success value.
-  void RunWithBackendOnFileThread(ExtensionSettingsBackend* backend);
+  void RunWithStorageOnFileThread(
+      scoped_refptr<ExtensionSettingsObserverList> observers,
+      ExtensionSettingsStorage* storage);
 };
 
 class GetSettingsFunction : public SettingsFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.settings.get");
 
  protected:
   virtual bool RunWithStorage(
-      ExtensionSettingsBackend* backend,
+      ExtensionSettingsObserverList* observers,
       ExtensionSettingsStorage* storage) OVERRIDE;
 };
 
 class SetSettingsFunction : public SettingsFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.settings.set");
 
  protected:
   virtual bool RunWithStorage(
-      ExtensionSettingsBackend* backend,
+      ExtensionSettingsObserverList* observers,
       ExtensionSettingsStorage* storage) OVERRIDE;
 };
 
 class RemoveSettingsFunction : public SettingsFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.settings.remove");
 
  protected:
   virtual bool RunWithStorage(
-      ExtensionSettingsBackend* backend,
+      ExtensionSettingsObserverList* observers,
       ExtensionSettingsStorage* storage) OVERRIDE;
 };
 
 class ClearSettingsFunction : public SettingsFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.settings.clear");
 
  protected:
   virtual bool RunWithStorage(
-      ExtensionSettingsBackend* backend,
+      ExtensionSettingsObserverList* observers,
       ExtensionSettingsStorage* storage) OVERRIDE;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_API_H_