Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Unified Diff: content/test/test_url_fetcher_factory.h

Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/url_fetcher_delegate.h ('k') | content/test/test_url_fetcher_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_url_fetcher_factory.h
===================================================================
--- content/test/test_url_fetcher_factory.h (revision 107061)
+++ content/test/test_url_fetcher_factory.h (working copy)
@@ -71,10 +71,10 @@
// Unique ID in our factory.
int id() const { return id_; }
- // URL we were created with. Because of how we're using URLFetcher url()
- // always returns an empty URL. Chances are you'll want to use original_url()
- // in your tests.
- virtual const GURL& original_url() const OVERRIDE;
+ // URL we were created with. Because of how we're using URLFetcher GetUrl()
+ // always returns an empty URL. Chances are you'll want to use
+ // GetOriginalUrl() in your tests.
+ virtual const GURL& GetOriginalUrl() const OVERRIDE;
// Returns the data uploaded on this URLFetcher.
const std::string& upload_data() const { return URLFetcher::upload_data(); }
@@ -88,18 +88,18 @@
}
void set_url(const GURL& url) { fake_url_ = url; }
- virtual const GURL& url() const OVERRIDE;
+ virtual const GURL& GetUrl() const OVERRIDE;
void set_status(const net::URLRequestStatus& status);
- virtual const net::URLRequestStatus& status() const OVERRIDE;
+ virtual const net::URLRequestStatus& GetStatus() const OVERRIDE;
void set_response_code(int response_code) {
fake_response_code_ = response_code;
}
- virtual int response_code() const OVERRIDE;
+ virtual int GetResponseCode() const OVERRIDE;
void set_cookies(const net::ResponseCookies& c) { fake_cookies_ = c; }
- virtual const net::ResponseCookies& cookies() const OVERRIDE;
+ virtual const net::ResponseCookies& GetCookies() const OVERRIDE;
void set_was_fetched_via_proxy(bool flag);
« no previous file with comments | « content/public/common/url_fetcher_delegate.h ('k') | content/test/test_url_fetcher_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698