chrome/service/gaia/service_gaia_authenticator.cc - Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/gaia/service_gaia_authenticator.cc

Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/gaia/service_gaia_authenticator.h ('k') | content/browser/geolocation/network_location_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/gaia/service_gaia_authenticator.cc

===================================================================

--- chrome/service/gaia/service_gaia_authenticator.cc (revision 107061)

+++ chrome/service/gaia/service_gaia_authenticator.cc (working copy)

@@ -65,16 +65,17 @@

const std::string& post_body) {

DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());

URLFetcher* request = new URLFetcher(post_url, URLFetcher::POST, this);

- request->set_request_context(

+ request->SetRequestContext(

g_service_process->GetServiceURLRequestContextGetter());

- request->set_upload_data("application/x-www-form-urlencoded", post_body);

+ request->SetUploadData("application/x-www-form-urlencoded", post_body);

request->Start();

}

// content::URLFetcherDelegate implementation

-void ServiceGaiaAuthenticator::OnURLFetchComplete(const URLFetcher* source) {

+void ServiceGaiaAuthenticator::OnURLFetchComplete(

+ const content::URLFetcher* source) {

DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());

- http_response_code_ = source->response_code();

+ http_response_code_ = source->GetResponseCode();

source->GetResponseAsString(&response_data_);

delete source;

// Add an extra reference because we want http_post_completed_ to remain