chrome/browser/safe_browsing/client_side_detection_service.h - Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/testing_policy_url_fetcher_factory.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service.h

===================================================================

--- chrome/browser/safe_browsing/client_side_detection_service.h (revision 107061)

+++ chrome/browser/safe_browsing/client_side_detection_service.h (working copy)

@@ -81,7 +81,7 @@

}

// From the content::URLFetcherDelegate interface.

- virtual void OnURLFetchComplete(const URLFetcher* source) OVERRIDE;

+ virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;

// content::NotificationObserver overrides:

virtual void Observe(int type,

@@ -207,7 +207,7 @@

// Called by OnURLFetchComplete to handle the response from fetching the

// model.

- void HandleModelResponse(const URLFetcher* source,

+ void HandleModelResponse(const content::URLFetcher* source,

const GURL& url,

const net::URLRequestStatus& status,

int response_code,

@@ -216,7 +216,7 @@

// Called by OnURLFetchComplete to handle the server response from

// sending the client-side phishing request.

- void HandlePhishingVerdict(const URLFetcher* source,

+ void HandlePhishingVerdict(const content::URLFetcher* source,

const GURL& url,

const net::URLRequestStatus& status,

int response_code,

@@ -263,12 +263,13 @@

std::string model_str_;

scoped_ptr<ClientSideModel> model_;

scoped_ptr<base::TimeDelta> model_max_age_;

- scoped_ptr<URLFetcher> model_fetcher_;

+ scoped_ptr<content::URLFetcher> model_fetcher_;

// Map of client report phishing request to the corresponding callback that

// has to be invoked when the request is done.

struct ClientReportInfo;

- std::map<const URLFetcher*, ClientReportInfo*> client_phishing_reports_;

+ std::map<const content::URLFetcher*, ClientReportInfo*>

+ client_phishing_reports_;

// Cache of completed requests. Used to satisfy requests for the same urls

// as long as the next request falls within our caching window (which is