chrome/browser/extensions/extension_updater.h - Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_updater.h

Issue 8375039: Create a content::UrlFetcher interface that lives in content/public/common and convert users to i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_management_browsertest.cc ('k') | chrome/browser/extensions/extension_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_updater.h

===================================================================

--- chrome/browser/extensions/extension_updater.h (revision 107061)

+++ chrome/browser/extensions/extension_updater.h (working copy)

@@ -255,7 +255,7 @@

base::TimeDelta DetermineFirstCheckDelay();

// content::URLFetcherDelegate interface.

- virtual void OnURLFetchComplete(const URLFetcher* source) OVERRIDE;

+ virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;

// These do the actual work when a URL fetch completes.

virtual void OnManifestFetchComplete(const GURL& url,

@@ -263,7 +263,7 @@

int response_code,

const std::string& data);

- virtual void OnCRXFetchComplete(const URLFetcher* source,

+ virtual void OnCRXFetchComplete(const content::URLFetcher* source,

const GURL& url,

const net::URLRequestStatus& status,

int response_code);

@@ -346,8 +346,8 @@

base::WeakPtrFactory<ExtensionUpdater> weak_ptr_factory_;

// Outstanding url fetch requests for manifests and updates.

- scoped_ptr<URLFetcher> manifest_fetcher_;

- scoped_ptr<URLFetcher> extension_fetcher_;

+ scoped_ptr<content::URLFetcher> manifest_fetcher_;

+ scoped_ptr<content::URLFetcher> extension_fetcher_;

// Pending manifests and extensions to be fetched when the appropriate fetcher

// is available.

« no previous file with comments | « chrome/browser/extensions/extension_management_browsertest.cc ('k') | chrome/browser/extensions/extension_updater.cc » ('j') | no next file with comments »