Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 8375035: Fix Typo in r106982 (Closed)

Created:
9 years, 2 months ago by jasonwkim
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

IRT name was incorrect Activate IRT building on ARM for NaCl. In order for this to be on for real, the PNaCl toolchain still needs to available Since NaCl is still turned off by default on ARM, this code should be a no-op for all other cases. This also moves the compilation a step forward for ARM. There is a bootstrap dependency on memset on ARM - so SYSROOT on the ChromiumOS chroot is required to gain access to libc. R=bradnelson,robertm BUG=http://code.google.com/p/chromium/issues/detail?id=61695 BUG=http://code.google.com/p/chromium/issues/detail?id=38909 BUG=http://code.google.com/p/nativeclient/issues/detail?id=135 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/nacl.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jasonwkim
PTAL
9 years, 2 months ago (2011-10-24 22:28:55 UTC) #1
bradn
lgtm
9 years, 2 months ago (2011-10-24 22:53:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jasonwkim@google.com/8375035/1
9 years, 2 months ago (2011-10-24 23:37:47 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 02:05:40 UTC) #4
Change committed as 107040

Powered by Google App Engine
This is Rietveld 408576698