Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3536)

Unified Diff: chrome/browser/extensions/webstore_install_helper.h

Issue 8375034: Update WebstoreInstaller to be ref counted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_install_helper.h
diff --git a/chrome/browser/extensions/webstore_install_helper.h b/chrome/browser/extensions/webstore_install_helper.h
index 916054841657fd43629115e338727ff45e48173a..86202819bac034edeb41e3c04a93c4ad5958b7e1 100644
--- a/chrome/browser/extensions/webstore_install_helper.h
+++ b/chrome/browser/extensions/webstore_install_helper.h
@@ -41,12 +41,14 @@ class WebstoreInstallHelper : public UtilityProcessHost::Client,
// Called when we've successfully parsed the manifest and decoded the icon
// in the utility process. Ownership of parsed_manifest is transferred.
virtual void OnWebstoreParseSuccess(
+ const std::string& id,
const SkBitmap& icon,
base::DictionaryValue* parsed_manifest) = 0;
// Called to indicate a parse failure. The |result_code| parameter should
// indicate whether the problem was with the manifest or icon.
virtual void OnWebstoreParseFailure(
+ const std::string& id,
InstallHelperResultCode result_code,
const std::string& error_message) = 0;
};
@@ -54,6 +56,7 @@ class WebstoreInstallHelper : public UtilityProcessHost::Client,
// Only one of |icon_data| (based64-encoded icon data) or |icon_url| can be
// specified, but it is legal for both to be empty.
WebstoreInstallHelper(Delegate* delegate,
+ const std::string& id,
const std::string& manifest,
const std::string& icon_data,
const GURL& icon_url,
@@ -83,6 +86,9 @@ class WebstoreInstallHelper : public UtilityProcessHost::Client,
// The client who we'll report results back to.
Delegate* delegate_;
+ // The extension id of the manifest we're parsing.
+ std::string id_;
+
// The manifest to parse.
std::string manifest_;
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698