Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7265)

Unified Diff: chrome/browser/extensions/webstore_install_helper.cc

Issue 8375034: Update WebstoreInstaller to be ref counted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_install_helper.h ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_install_helper.cc
diff --git a/chrome/browser/extensions/webstore_install_helper.cc b/chrome/browser/extensions/webstore_install_helper.cc
index 5a54041f70e8145f35bb873cd918c582e9a3cba1..6b3db85b503981076d4319d7e379b5c4b1273048 100644
--- a/chrome/browser/extensions/webstore_install_helper.cc
+++ b/chrome/browser/extensions/webstore_install_helper.cc
@@ -22,11 +22,13 @@ const char kImageDecodeError[] = "Image decode failed";
WebstoreInstallHelper::WebstoreInstallHelper(
Delegate* delegate,
+ const std::string& id,
const std::string& manifest,
const std::string& icon_data,
const GURL& icon_url,
net::URLRequestContextGetter* context_getter)
: delegate_(delegate),
+ id_(id),
manifest_(manifest),
icon_base64_data_(icon_data),
icon_url_(icon_url),
@@ -177,7 +179,7 @@ void WebstoreInstallHelper::ReportResultsIfComplete() {
void WebstoreInstallHelper::ReportResultFromUIThread() {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
if (error_.empty() && parsed_manifest_.get())
- delegate_->OnWebstoreParseSuccess(icon_, parsed_manifest_.release());
+ delegate_->OnWebstoreParseSuccess(id_, icon_, parsed_manifest_.release());
else
- delegate_->OnWebstoreParseFailure(parse_error_, error_);
+ delegate_->OnWebstoreParseFailure(id_, parse_error_, error_);
}
« no previous file with comments | « chrome/browser/extensions/webstore_install_helper.h ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698