Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4320)

Unified Diff: chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm

Issue 8375027: Implement notifications for the DisplayBalloon method on Linux and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixing profile usage. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm
diff --git a/chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm b/chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm
index 81042985850eed5f9f01d3ae49a82bc907c18d27..98323585ec0736d0c6ac2c3058581b134fca8362 100644
--- a/chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm
+++ b/chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm
@@ -79,9 +79,7 @@ void StatusIconMac::SetToolTip(const string16& tool_tip) {
void StatusIconMac::DisplayBalloon(const SkBitmap& icon,
const string16& title,
const string16& contents) {
- // TODO(atwilson): Figure out the right UI to display here when actually
- // needed (not yet called).
- // http://crbug.com/74970
+ notification_.DisplayBalloon(icon, title, contents);
Andrew T Wilson (Slow) 2011/10/26 22:20:26 I think we need to have identical behavior across
Leandro GraciĆ” Gil 2011/10/26 23:10:02 Done.
}
void StatusIconMac::UpdatePlatformContextMenu(ui::MenuModel* menu) {

Powered by Google App Engine
This is Rietveld 408576698