Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: chrome/browser/ui/cocoa/status_icons/status_icon_mac.h

Issue 8375027: Implement notifications for the DisplayBalloon method on Linux and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixing DisplayBalloon argument order (good). Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/status_icons/status_icon_mac.h
diff --git a/chrome/browser/ui/cocoa/status_icons/status_icon_mac.h b/chrome/browser/ui/cocoa/status_icons/status_icon_mac.h
index ff6e078e01da0b1993e067fe0650281baeee9536..b61dc4a2bd4d05b9f1d80b1218894b6ef0820969 100644
--- a/chrome/browser/ui/cocoa/status_icons/status_icon_mac.h
+++ b/chrome/browser/ui/cocoa/status_icons/status_icon_mac.h
@@ -11,13 +11,13 @@
#include "base/compiler_specific.h"
#include "base/memory/scoped_nsobject.h"
#include "base/string16.h"
-#include "chrome/browser/status_icons/status_icon.h"
+#include "chrome/browser/status_icons/desktop_notification_balloon_impl.h"
class SkBitmap;
@class NSStatusItem;
@class StatusItemController;
-class StatusIconMac : public StatusIcon {
+class StatusIconMac : public DesktopNotificationBalloonImpl {
Andrew T Wilson (Slow) 2011/10/26 01:21:18 See my previous note - I think this should be a he
Leandro GraciĆ” Gil 2011/10/26 13:52:00 Done.
public:
StatusIconMac();
virtual ~StatusIconMac();
@@ -26,9 +26,6 @@ class StatusIconMac : public StatusIcon {
virtual void SetImage(const SkBitmap& image) OVERRIDE;
virtual void SetPressedImage(const SkBitmap& image) OVERRIDE;
virtual void SetToolTip(const string16& tool_tip) OVERRIDE;
- virtual void DisplayBalloon(const SkBitmap& icon,
- const string16& title,
- const string16& contents) OVERRIDE;
protected:
// Overridden from StatusIcon.

Powered by Google App Engine
This is Rietveld 408576698