Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 8375012: Change panel overflow to not close any open panels. (Closed)

Created:
9 years, 2 months ago by jennb
Modified:
9 years, 2 months ago
CC:
chromium-reviews, jennb, prasadt, jianli, Dmitry Titov, dcheng, Paweł Hajdan Jr.
Visibility:
Public.

Description

Change panel overflow to not close any open panels. Extra panels that don't fit on screen are allowed to be opened off-screen. On Linux, the WM may force the overflow panels to remain on-screen using overlapping. Maximum panel width is no longer affected by the remaining available screen area now that panels are allowed to overflow the available screen area. BUG=100185 TEST=PanelBrowserTest.CreatePanelOnOverflow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106840

Patch Set 1 #

Total comments: 1

Patch Set 2 : Commend updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -107 lines) Patch
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +25 lines, -28 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 6 chunks +11 lines, -71 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jennb
Linux WM will keep overflow panels on screen and overlap them according to its whim. ...
9 years, 2 months ago (2011-10-21 22:18:14 UTC) #1
jianli
LGTM. Please also update the description about our change to auto-resizing width growing algorithm. http://codereview.chromium.org/8375012/diff/1/chrome/browser/ui/panels/panel_manager.cc ...
9 years, 2 months ago (2011-10-21 22:37:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/8375012/3001
9 years, 2 months ago (2011-10-22 00:33:27 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-22 02:23:10 UTC) #4
Change committed as 106840

Powered by Google App Engine
This is Rietveld 408576698