Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 8374025: Move RLZ extension API to rlz directory. (Closed)

Created:
9 years, 2 months ago by Aaron Boodman
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move RLZ extension api implementation to rlz directory. We're moving all the extension api implementations out of browser/extensions into the directory with the code they are automating. BUG=101244 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107064

Patch Set 1 #

Patch Set 2 : remove api completely #

Patch Set 3 : remove test too #

Patch Set 4 : move instead #

Patch Set 5 : fix include in apitest #

Patch Set 6 : header again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -359 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_rlz_apitest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/extensions/extension_rlz_module.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/extensions/extension_rlz_module.cc View 1 chunk +0 lines, -211 lines 0 comments Download
A + chrome/browser/rlz/rlz_extension_api.h View 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/rlz/rlz_extension_api.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/rlz/rlz_extension_apitest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Aaron Boodman
9 years, 2 months ago (2011-10-22 06:51:16 UTC) #1
Jói
Code change LGTM. > Nobody's using it now, right? I think you're right. Adding Roger ...
9 years, 2 months ago (2011-10-23 08:18:04 UTC) #2
Roger Tawa OOO till Jul 10th
Please don't remove, will be used soon. On Oct 23, 2011 4:18 AM, "Jói Sigurðsson" ...
9 years, 2 months ago (2011-10-24 12:52:17 UTC) #3
Aaron Boodman
On 2011/10/24 12:52:17, Roger Tawa wrote: > Please don't remove, will be used soon. Ok, ...
9 years, 2 months ago (2011-10-24 19:04:54 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm Thanks Aaron.
9 years, 2 months ago (2011-10-24 20:03:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8374025/10001
9 years, 2 months ago (2011-10-25 03:37:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8374025/6002
9 years, 2 months ago (2011-10-25 03:40:44 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 05:01:09 UTC) #8
Change committed as 107064

Powered by Google App Engine
This is Rietveld 408576698