Issue 8374024: Move infobar extension API implementation to infobars dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8374024: Move infobar extension API implementation to infobars dir. (Closed)

Created:
9 years, 2 months ago by Aaron Boodman

Modified:
9 years, 2 months ago

Reviewers:
Finnur, commit-bot: I haz the power

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move infobar extension API implementation to infobars dir. We're moving all the extension api implementations out of browser/extensions into the directory with the code they are automating. BUG=101244 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106932

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -163 lines)			Patch
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/extensions/extension_infobar_apitest.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	chrome/browser/extensions/extension_infobar_module.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/browser/extensions/extension_infobar_module.cc	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	chrome/browser/extensions/extension_infobar_module_constants.h	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/browser/extensions/extension_infobar_module_constants.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
A +	chrome/browser/infobars/infobar_extension_api.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/infobars/infobar_extension_api.cc	View	2 chunks	+15 lines, -7 lines	0 comments	Download
A +	chrome/browser/infobars/infobar_extension_apitest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

This is a pure rename, no functionality change. Also move constants into history_extension_api.cc. The reason ...

9 years, 2 months ago (2011-10-22 06:29:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8374024/1

9 years, 2 months ago (2011-10-24 15:23:46 UTC) #3

Change committed as 106932

Expand Messages | Collapse Messages