Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8374023: Move bookmarks extension api implementation to bookmarks dir (Closed)

Created:
9 years, 2 months ago by Aaron Boodman
Modified:
9 years, 1 month ago
CC:
chromium-reviews, ncarter (slow), Raghu Simha, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., estade+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Move bookmarks extension api implementation to bookmarks dir. We're moving all the extension api implementations out of browser/extensions into the directory with the code they are automating. BUG=101244 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107069

Patch Set 1 #

Patch Set 2 : fix deps, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -2307 lines) Patch
A + chrome/browser/bookmarks/bookmark_extension_api.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_api.cc View 22 chunks +30 lines, -30 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_api_constants.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_api_constants.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_helpers.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_helpers.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_manager_extension_api.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/bookmarks/bookmark_manager_extension_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_bookmark_helpers.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/extension_bookmark_helpers.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/extensions/extension_bookmark_manager_api.h View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/extensions/extension_bookmark_manager_api.cc View 1 chunk +0 lines, -487 lines 0 comments Download
D chrome/browser/extensions/extension_bookmark_manager_apitest.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/extension_bookmarks_apitest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/extensions/extension_bookmarks_module.h View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/extensions/extension_bookmarks_module.cc View 1 chunk +0 lines, -943 lines 0 comments Download
D chrome/browser/extensions/extension_bookmarks_module_constants.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/extensions/extension_bookmarks_module_constants.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/extensions/extension_bookmarks_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/bookmarks_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
This is just a pure move, no functionality change.
9 years, 2 months ago (2011-10-22 05:40:09 UTC) #1
akalin
sync LGTM
9 years, 2 months ago (2011-10-22 06:19:28 UTC) #2
sky
Rubber stamp LGTM
9 years, 1 month ago (2011-10-24 15:05:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8374023/5001
9 years, 1 month ago (2011-10-24 19:02:27 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-24 19:05:07 UTC) #5
Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for diner.
Ping the relevant dude on a on-needed basis.

Powered by Google App Engine
This is Rietveld 408576698