src/ast.cc - Issue 8373029: [hydrogen] optimize switch with string clauses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 8373029: [hydrogen] optimize switch with string clauses (Closed) Base URL: gh:v8/v8@master

Patch Set: use type feedback to bailout switches with known beforehand string(non-symbol) comparison Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index d5282d24efd3ea4de114e4a95d7fd75ceac9e9ee..69ea722bf296045018043666de592d3954c98f16 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -695,6 +695,10 @@ void CaseClause::RecordTypeFeedback(TypeFeedbackOracle* oracle) {

TypeInfo info = oracle->SwitchType(this);

if (info.IsSmi()) {

compare_type_ = SMI_ONLY;

+ } else if (info.IsSymbol()) {

+ compare_type_ = SYMBOL_ONLY;

+ } else if (info.IsNonSymbol()) {

+ compare_type_ = STRING_ONLY;

} else if (info.IsNonPrimitive()) {

compare_type_ = OBJECT_ONLY;

} else {

« no previous file with comments | « src/ast.h ('k') | src/hydrogen.h » ('j') | src/hydrogen.cc » ('J')