chrome/browser/extensions/extension_tabs_module_constants.cc - Issue 8373027: Prevent incognito windows from opening when incognito mode is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module_constants.cc

Issue 8373027: Prevent incognito windows from opening when incognito mode is disabled. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Moved test to extension_tabs_test.cc. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tabs_module_constants.h ('k') | chrome/browser/extensions/extension_tabs_test.cc » ('j') | chrome/browser/extensions/extension_tabs_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_module_constants.cc

diff --git a/chrome/browser/extensions/extension_tabs_module_constants.cc b/chrome/browser/extensions/extension_tabs_module_constants.cc

index 8c63750bc2a7a169e8e0cb765dd68969a0cf62fd..942235853b66a24c122bc406414180be76f0cb01 100644

--- a/chrome/browser/extensions/extension_tabs_module_constants.cc

+++ b/chrome/browser/extensions/extension_tabs_module_constants.cc

@@ -75,6 +75,8 @@ const char kTabStripNotEditableError[] =

const char kNoSelectedTabError[] = "No selected tab";

const char kNoHighlightedTabError[] = "No highlighted tab";

const char kIncognitoModeIsDisabled[] = "Incognito mode is disabled.";

+const char kIncognitoModeIsForced[] = "Incognito mode is forced. "

+ "Cannot open normal windows.";

const char kURLsNotAllowedInIncognitoError[] = "Cannot open URL \"*\" "

"in an incognito window.";

const char kInvalidUrlError[] = "Invalid url: \"*\".";