Prevent incognito windows from opening when incognito mode is disabled.

chrome/browser/extensions/extension_tabs_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tabs_module.h"
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stringprintf.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
+#include "chrome/browser/extensions/extension_tabs_module_constants.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
-#include "chrome/browser/extensions/extension_tabs_module_constants.h"
+#include "chrome/browser/prefs/incognito_mode_prefs.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "ui/gfx/rect.h"
 
 using namespace extension_function_test_utils;
 
 namespace {
 
@@ skipping 92 matching lines @@
   update_tab_function->set_extension(empty_extension.get());
   // Without a callback the function will not generate a result.
   update_tab_function->set_has_callback(true);
 
   scoped_ptr<base::Value> result(RunFunctionAndReturnResult(
           update_tab_function.get(),
           "[null, {\"url\": \"neutrinos\"}]",
           browser()));
   EXPECT_EQ(base::Value::TYPE_NULL, result->GetType());
 }
+
+IN_PROC_BROWSER_TEST_F(ExtensionTabsTest,
+                       DontCreateNormalWindowWhenIncognitoForced) {
+  static const char kArgsWithoutExplicitIncognitoParam[] =
+      "[{\"url\": \"about:blank\"}]";
+  static const char kArgsWithExplicitIncognitoParam[] =
+      "[{\"url\": \"about:blank\", \"incognito\": false }]";
+  // Force Incognito mode.
+  IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(),
+                                      IncognitoModePrefs::FORCED);
+  // Run without an explicit "incognito" param.
+  EXPECT_TRUE(MatchPattern(
+      RunFunctionAndReturnError(
+          new CreateWindowFunction(),
+          kArgsWithoutExplicitIncognitoParam,

[Aaron Boodman, 2011/10/25 08:35:09]

In this case, shouldn't we default to incognito? Seems like most extension
developers won't be aware of this case and won't code to it. So without a
sensible default, you're essentially guaranteeing that any extension that calls
window.create() won't work.

[rustema, 2011/10/26 07:13:41]

Makes sense. Done.

+          browser()),
+      extension_tabs_module_constants::kIncognitoModeIsForced));
+
+  // Run with an explicit "incognito" param.
+  EXPECT_TRUE(MatchPattern(
+      RunFunctionAndReturnError(
+          new CreateWindowFunction(),
+          kArgsWithExplicitIncognitoParam,
+          browser()),
+      extension_tabs_module_constants::kIncognitoModeIsForced));
+
+  // Now try opening a normal window from incognito window.
+  Browser* incognito_browser = CreateIncognitoBrowser();
+  // Run without an explicit "incognito" param.
+  EXPECT_TRUE(MatchPattern(
+      RunFunctionAndReturnError(
+          new CreateWindowFunction(),
+          kArgsWithoutExplicitIncognitoParam,
+          incognito_browser),
+      extension_tabs_module_constants::kIncognitoModeIsForced));
+
+  // Run with an explicit "incognito" param.
+  EXPECT_TRUE(MatchPattern(
+      RunFunctionAndReturnError(
+          new CreateWindowFunction(),
+          kArgsWithExplicitIncognitoParam,
+          incognito_browser),
+      extension_tabs_module_constants::kIncognitoModeIsForced));
+}
+
+IN_PROC_BROWSER_TEST_F(ExtensionTabsTest,
+                       DontCreateIncognitoWindowWhenIncognitoDisabled) {
+  static const char kArgs[] =
+      "[{\"url\": \"about:blank\", \"incognito\": true }]";
+
+  Browser* incognito_browser = CreateIncognitoBrowser();
+  // Disable Incognito mode.
+  IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(),
+                                      IncognitoModePrefs::DISABLED);
+  // Run in normal window.
+  EXPECT_TRUE(MatchPattern(
+      RunFunctionAndReturnError(
+          new CreateWindowFunction(),
+          kArgs,
+          browser()),
+      extension_tabs_module_constants::kIncognitoModeIsDisabled));
+
+  // Run in incognito window.
+  EXPECT_TRUE(MatchPattern(
+      RunFunctionAndReturnError(
+          new CreateWindowFunction(),
+          kArgs,
+          incognito_browser),
+      extension_tabs_module_constants::kIncognitoModeIsDisabled));
+}