Issue 8373016: views: Change the remaining std::wstring entries to string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8373016: views: Change the remaining std::wstring entries to string16. (Closed)

Created:
9 years, 2 months ago by tfarina

Modified:
9 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

views: Change the remaining std::wstring entries to string16. BUG=68267 R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106920

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -24 lines)			Patch
M	chrome/browser/ui/views/about_chrome_view.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	views/drag_utils.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/view_text_utils.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	views/view_text_utils.cc	View	6 chunks	+7 lines, -5 lines	0 comments	Download
M	views/view_unittest.cc	View	3 chunks	+6 lines, -6 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/8373016/diff/1/views/view_unittest.cc File views/view_unittest.cc (right): http://codereview.chromium.org/8373016/diff/1/views/view_unittest.cc#newcode944 views/view_unittest.cc:944: EXPECT_EQ(kReadOnlyText, string16(buffer)); I believe these should rename wstring since ...

9 years, 2 months ago (2011-10-24 14:56:08 UTC) #2

tfarina

9 years, 2 months ago (2011-10-24 15:19:42 UTC) #3

LGTM

Expand Messages | Collapse Messages