Fixing visibility transitions for Instant.

chrome/browser/ui/browser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 4293 matching lines @@
   command_updater_.UpdateCommandEnabled(IDC_SYNC_BOOKMARKS,
       show_main_ui && profile_->GetOriginalProfile()->IsSyncAccessible());
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, InstantDelegate implementation:
 
 void Browser::ShowInstant(TabContentsWrapper* preview_contents) {
   DCHECK(instant_->tab_contents() == GetSelectedTabContentsWrapper());
   window_->ShowInstant(preview_contents);
+
+  instant_->tab_contents()->tab_contents()->HideContents();

[sreeram, 2011/10/25 23:26:48]

Why not just: GetSelectedTabContents()->HideContents()?

[Shishir, 2011/10/25 23:46:26]

Done.

+  preview_contents->tab_contents()->ShowContents();
 }
 
 void Browser::HideInstant() {
   window_->HideInstant();
+  instant_->tab_contents()->tab_contents()->ShowContents();

[sreeram, 2011/10/25 23:26:48]

Same as before, why not just use GetSelectedTabContents()?

[Shishir, 2011/10/25 23:46:26]

Done.

+  if (instant_->GetPreviewContents())
+    instant_->GetPreviewContents()->tab_contents()->HideContents();
 }
 
 void Browser::CommitInstant(TabContentsWrapper* preview_contents) {
   TabContentsWrapper* tab_contents = instant_->tab_contents();
   int index =
       tab_handler_->GetTabStripModel()->GetIndexOfTabContents(tab_contents);
   DCHECK_NE(TabStripModel::kNoTab, index);
   // TabStripModel takes ownership of preview_contents.
   tab_handler_->GetTabStripModel()->ReplaceTabContentsAt(
       index, preview_contents);
@@ skipping 1171 matching lines @@
 }
 
 void Browser::UpdateFullscreenExitBubbleContent() {
   GURL url;
   if (fullscreened_tab_)
     url = fullscreened_tab_->tab_contents()->GetURL();
 
   window_->UpdateFullscreenExitBubbleContent(
       url, GetFullscreenExitBubbleType());
 }