Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 8373006: Rename setVisibility to setVisibilityCHROMIUM and expose as GL_CHROIMIUM_set_visibility extension. (Closed)

Created:
9 years, 2 months ago by nduca
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org, mmocny
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rename setVisibility to setVisibilityCHROMIUM and expose as GL_CHROIMIUM_set_visibility extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107034

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nduca
9 years, 2 months ago (2011-10-21 20:38:16 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for doing this. Because WebKit still has setVisibility as a pure virtual, you'll need ...
9 years, 2 months ago (2011-10-22 00:40:21 UTC) #2
nduca
On 2011/10/22 00:40:21, kbr wrote: > Thanks for doing this. Because WebKit still has setVisibility ...
9 years, 2 months ago (2011-10-22 02:07:51 UTC) #3
Ken Russell (switch to Gerrit)
On 2011/10/22 02:07:51, nduca wrote: > On 2011/10/22 00:40:21, kbr wrote: > > Thanks for ...
9 years, 2 months ago (2011-10-22 02:14:17 UTC) #4
nduca
9 years, 2 months ago (2011-10-25 01:28:15 UTC) #5
Note: this did have try job runs, they dont show up here for some reason. Sigh.

Powered by Google App Engine
This is Rietveld 408576698