Issue 8373003: Implement WebKitPlatformSupport::isTraceCategoryEnabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8373003: Implement WebKitPlatformSupport::isTraceCategoryEnabled. (Closed)

Created:
9 years, 2 months ago by nduca

Modified:
9 years, 2 months ago

Reviewers:
jamesr, tony

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Implement WebKitPlatformSupport::isTraceCategoryEnabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107093

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	webkit/glue/webkitplatformsupport_impl.h	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	webkit/glue/webkitplatformsupport_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

I don't have any context for this change. LGTM (for OWNERS) if jamesr says it's ...

9 years, 2 months ago (2011-10-21 23:20:06 UTC) #2

nduca

On 2011/10/21 23:20:06, tony wrote: > I don't have any context for this change. LGTM ...

9 years, 2 months ago (2011-10-25 10:05:27 UTC) #3

jamesr

9 years, 2 months ago (2011-10-25 15:16:41 UTC) #4

lgtm to me as well, although I agree with Darin that inverting this would be
better

http://codereview.chromium.org/8373003/diff/1/webkit/glue/webkitplatformsuppo...
File webkit/glue/webkitplatformsupport_impl.h (right):

http://codereview.chromium.org/8373003/diff/1/webkit/glue/webkitplatformsuppo...
webkit/glue/webkitplatformsupport_impl.h:57: virtual bool
isTraceEventEnabledForCategory(const char* category) const;
On 2011/10/21 23:20:06, tony wrote:
> OVERRIDE?

No, do not OVERRIDE

Expand Messages | Collapse Messages