Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 8372081: Fix cross-tool check for readelf (Closed)

Created:
9 years, 1 month ago by Roland McGrath
Modified:
9 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master
Visibility:
Public.

Description

Fix cross-tool check for readelf This makes all stages of newlib's configury set $READELF to the proper cross-tool. This solves the problem that the configure test for .init_array support would get the wrong answer on Mac, because it was trying to use the native readelf and there wasn't any. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1096 TEST= toolchain trybot R=sehr@google.com Committed: http://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=590577e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1962 lines, -1531 lines) Patch
M Makefile.in View 1408 chunks +1536 lines, -1528 lines 0 comments Download
M configure View 10 chunks +423 lines, -3 lines 0 comments Download
M configure.ac View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roland McGrath
9 years, 1 month ago (2011-11-02 20:06:52 UTC) #1
sehr (please use chromium)
9 years, 1 month ago (2011-11-02 20:13:31 UTC) #2
LGTM and thanks!

Powered by Google App Engine
This is Rietveld 408576698