Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Unified Diff: content/renderer/render_view_impl.cc

Issue 8372066: Revert 108268 - Revert 108214 - Try to fix a renderer crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc (revision 108293)
+++ content/renderer/render_view_impl.cc (working copy)
@@ -4306,10 +4306,10 @@
// Select the text in |replacement_range|, it will then be replaced by
// text added by the call to RenderWidget::OnImeConfirmComposition().
if (WebFrame* frame = webview()->focusedFrame()) {
- frame->setSelectionToRange(
- WebRange::fromDocumentRange(frame,
- replacement_range.start(),
- replacement_range.length()));
+ WebRange webrange = WebRange::fromDocumentRange(
+ frame, replacement_range.start(), replacement_range.length());
+ if (!webrange.isNull())
+ frame->setSelectionToRange(webrange);
}
}
RenderWidget::OnImeConfirmComposition(text, replacement_range);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698