Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/elements.h

Issue 8372064: Fix setting array length to be ES5 conform. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Daniel Clifford. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 26 matching lines...) Expand all
37 // ElementsKinds. 37 // ElementsKinds.
38 class ElementsAccessor { 38 class ElementsAccessor {
39 public: 39 public:
40 ElementsAccessor() { } 40 ElementsAccessor() { }
41 virtual ~ElementsAccessor() { } 41 virtual ~ElementsAccessor() { }
42 virtual MaybeObject* Get(FixedArrayBase* backing_store, 42 virtual MaybeObject* Get(FixedArrayBase* backing_store,
43 uint32_t key, 43 uint32_t key,
44 JSObject* holder, 44 JSObject* holder,
45 Object* receiver) = 0; 45 Object* receiver) = 0;
46 46
47 // Modifies the length data property as specified for JSArrays and resizes
48 // the underlying backing store accordingly.
49 virtual MaybeObject* SetLength(JSObject* holder,
50 Object* new_length) = 0;
51
47 virtual MaybeObject* Delete(JSObject* holder, 52 virtual MaybeObject* Delete(JSObject* holder,
48 uint32_t key, 53 uint32_t key,
49 JSReceiver::DeleteMode mode) = 0; 54 JSReceiver::DeleteMode mode) = 0;
50 55
51 virtual MaybeObject* AddElementsToFixedArray(FixedArrayBase* from, 56 virtual MaybeObject* AddElementsToFixedArray(FixedArrayBase* from,
52 FixedArray* to, 57 FixedArray* to,
53 JSObject* holder, 58 JSObject* holder,
54 Object* receiver) = 0; 59 Object* receiver) = 0;
55 60
56 // Returns a shared ElementsAccessor for the specified ElementsKind. 61 // Returns a shared ElementsAccessor for the specified ElementsKind.
(...skipping 29 matching lines...) Expand all
86 91
87 private: 92 private:
88 static ElementsAccessor** elements_accessors_; 93 static ElementsAccessor** elements_accessors_;
89 94
90 DISALLOW_COPY_AND_ASSIGN(ElementsAccessor); 95 DISALLOW_COPY_AND_ASSIGN(ElementsAccessor);
91 }; 96 };
92 97
93 } } // namespace v8::internal 98 } } // namespace v8::internal
94 99
95 #endif // V8_ELEMENTS_H_ 100 #endif // V8_ELEMENTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698