Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8372041: Canonicalize types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 1042)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -2170,10 +2170,10 @@
if (instantiator_class.NumTypeParameters() == 0) {
// The type arguments are compile time constants.
TypeArguments& type_arguments = TypeArguments::ZoneHandle();
- const Type& type = Type::Handle(
+ Type& type = Type::Handle(
Type::NewParameterizedType(instantiator_class, type_arguments));
- const String& errmsg = String::Handle(
- ClassFinalizer::FinalizeTypeWhileParsing(type));
+ String& errmsg = String::Handle();
+ type = ClassFinalizer::FinalizeAndCanonicalizeType(type, &errmsg);
if (!errmsg.IsNull()) {
ErrorMsg(token_index, errmsg.ToCString());
}
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698