Issue 8372038: gtk/bookmarks: Update the label of some dialog buttons.

Issue 8372038: gtk/bookmarks: Update the label of some dialog buttons. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

gtk/bookmarks: Update the label of some dialog buttons. BUG=20053 TEST=see bug R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108219

Patch Set 2 : sky review -> enum ButtonType #

Total comments: 4

Patch Set 3 : BUTTON_TYPE_ and TODOs #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -39 lines)			Patch
M	chrome/browser/bookmarks/bookmark_folder_editor_controller.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/input_window_dialog.h	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/input_window_dialog_gtk.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/input_window_dialog_gtk.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/input_window_dialog_linux.cc	View	1 2	1 chunk	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/input_window_dialog_win.cc	View	1	9 chunks	+22 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/8372038/diff/1/chrome/browser/ui/input_window_dialog.h File chrome/browser/ui/input_window_dialog.h (right): http://codereview.chromium.org/8372038/diff/1/chrome/browser/ui/input_window_dialog.h#newcode37 chrome/browser/ui/input_window_dialog.h:37: bool is_new); Use an enum rather than this.

9 years, 1 month ago (2011-11-01 23:15:24 UTC) #2

tfarina

9 years, 1 month ago (2011-11-01 23:36:09 UTC) #3

sky

LGTM http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_window_dialog.h File chrome/browser/ui/input_window_dialog.h (right): http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_window_dialog.h#newcode17 chrome/browser/ui/input_window_dialog.h:17: BT_ADD, BT->BUTTON_TYPE_ http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_window_dialog_linux.cc File chrome/browser/ui/input_window_dialog_linux.cc (right): http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_window_dialog_linux.cc#newcode21 chrome/browser/ui/input_window_dialog_linux.cc:21: ...

9 years, 1 month ago (2011-11-01 23:55:31 UTC) #4

tfarina

9 years, 1 month ago (2011-11-02 00:05:42 UTC) #5

http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_wind...
File chrome/browser/ui/input_window_dialog.h (right):

http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_wind...
chrome/browser/ui/input_window_dialog.h:17: BT_ADD,
On 2011/11/01 23:55:31, sky wrote:
> BT->BUTTON_TYPE_

Done.

http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_wind...
File chrome/browser/ui/input_window_dialog_linux.cc (right):

http://codereview.chromium.org/8372038/diff/4001/chrome/browser/ui/input_wind...
chrome/browser/ui/input_window_dialog_linux.cc:21: #if defined(USE_AURA)
On 2011/11/01 23:55:31, sky wrote:
> Add a TODO to this and the next one to support type

Done.

Expand Messages | Collapse Messages