Ensure forced process swaps use the correct page_id and SiteInstance.

Ensure forced process swaps use the correct page_id and SiteInstance.

BUG=102408
TEST=See bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108186

[Charlie Reis, 2011-11-01 19:09:22]

This corrects a flaw in the fix for http://crbug.com/80621.  When forcing a
previous NavigationEntry to swap to an app or a non-app process, we need to
update the new SiteInstance's max_page_id and the entry's SiteInstance.

I really didn't want to change the contract of TabContents::NavigateToEntry, but
I did need to change the entry's SiteInstance before the navigation committed. 
(I suppose I could update the call sites instead, but that doesn't seem much
better.)  Please review.

In the mean time, I'll try to get a test for it.

[jam, 2011-11-01 19:14:33]

http://codereview.chromium.org/8372036/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/8372036/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:578: NavigationEntry& entry,
this is against the google style guide, so you will need to change it to a
pointer and update all the call sites.

[Charlie Reis, 2011-11-01 19:16:27]

http://codereview.chromium.org/8372036/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/8372036/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:578: NavigationEntry& entry,
On 2011/11/01 19:14:33, John Abd-El-Malek wrote:
> this is against the google style guide, so you will need to change it to a
> pointer and update all the call sites.

Will do.

[Charlie Reis, 2011-11-01 19:25:45]

http://codereview.chromium.org/8372036/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/8372036/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:578: NavigationEntry& entry,
On 2011/11/01 19:16:27, creis wrote:
> On 2011/11/01 19:14:33, John Abd-El-Malek wrote:
> > this is against the google style guide, so you will need to change it to a
> > pointer and update all the call sites.
> 
> Will do.

Done.

[Charlie Reis, 2011-11-01 21:17:27]

Added a test to prevent regression.  PTAL.

[jam, 2011-11-01 21:37:14]

lgtm

[jam, 2011-11-01 21:37:42]

should I revert my temp logging change now or in a few days?

[Charlie Reis, 2011-11-01 21:42:06]

Great.  Since Brett's offline, I'll go ahead with this.

On 2011/11/01 21:37:42, John Abd-El-Malek wrote:
> should I revert my temp logging change now or in a few days?

Let's wait a few days, just in case there are other ways we can get into that
situation.  It'd be nice to confirm that those crashes dry up.