Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: content/browser/download/download_file_manager.h

Issue 8372034: Created an interface for DownloadFile, for use in unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up download file interface and unit test class. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_manager.h
diff --git a/content/browser/download/download_file_manager.h b/content/browser/download/download_file_manager.h
index bf6e07beed78c91c2d7e7215b2e970b8ffd8c20d..2f5936971c8d2c8dc95e5c443f2240daa966c5ab 100644
--- a/content/browser/download/download_file_manager.h
+++ b/content/browser/download/download_file_manager.h
@@ -127,6 +127,14 @@ class CONTENT_EXPORT DownloadFileManager
return downloads_.size();
}
+ protected:
+ // Creates a new DownloadFile.
+ // Used only for testing, to create a MockDownloadFile instead.
+ DownloadFile* NewDownloadFile(
+ DownloadCreateInfo* info,
+ const DownloadRequestHandle& request_handle,
+ DownloadManager* download_manager);
Randy Smith (Not in Mondays) 2011/11/10 21:58:43 I don't think that this is used in this CL? I don
ahendrickson 2011/11/13 00:50:21 Done.
+
private:
friend class base::RefCountedThreadSafe<DownloadFileManager>;
friend class DownloadManagerTest;

Powered by Google App Engine
This is Rietveld 408576698