Created an interface for DownloadFile, for use in unit tests.

content/browser/download/save_file.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_SAVE_FILE_H_
 #define CONTENT_BROWSER_DOWNLOAD_SAVE_FILE_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/download/base_file.h"
 #include "content/browser/download/save_types.h"
 
 // SaveFile ----------------------------------------------------------------
 
 // These objects live exclusively on the file thread and handle the writing
 // operations for one save item. These objects live only for the duration that
 // the saving job is 'in progress': once the saving job has been completed or
 // canceled, the SaveFile is destroyed. One SaveFile object represents one item
 // in a save session.
-class SaveFile : public BaseFile {
+class SaveFile {
  public:
   explicit SaveFile(const SaveFileCreateInfo* info);
   virtual ~SaveFile();
 
+  // BaseFile delegated functions.

[Randy Smith (Not in Mondays), 2011/11/10 21:58:43]

nit: As I understand chrome custom (and I think there are some arguments
stronger than customer, though I don't remember them) pretty much anything that
isn't in the "simple accessor" category should be in a .cc file.

[ahendrickson, 2011/11/13 00:50:21]

Done.

+  net::Error Initialize(bool calculate_hash) {
+    return file_.Initialize(calculate_hash);
+  }
+  net::Error AppendDataToFile(const char* data, size_t data_len) {
+    return file_.AppendDataToFile(data, data_len);
+  }
+  net::Error Rename(const FilePath& full_path) {
+    return file_.Rename(full_path);
+  }
+  void Detach() { file_.Detach(); }
+  void Cancel() { file_.Cancel(); }
+  void Finish() { file_.Finish(); }
+  void AnnotateWithSourceInformation() {
+    file_.AnnotateWithSourceInformation();
+  }
+  FilePath full_path() const { return file_.full_path(); }
+  bool in_progress() const { return file_.in_progress(); }
+  int64 bytes_so_far() const { return file_.bytes_so_far(); }
+  bool GetSha256Hash(std::string* hash) {
+    return file_.GetSha256Hash(hash);
+  }
+  std::string DebugString() const { return file_.DebugString(); }
+
   // Accessors.
   int save_id() const { return info_->save_id; }
   int render_process_id() const { return info_->render_process_id; }
   int render_view_id() const { return info_->render_view_id; }
   int request_id() const { return info_->request_id; }
   SaveFileCreateInfo::SaveFileSource save_source() const {
     return info_->save_source;
   }
 
  private:
+  BaseFile file_;
   scoped_ptr<const SaveFileCreateInfo> info_;
 
   DISALLOW_COPY_AND_ASSIGN(SaveFile);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_SAVE_FILE_H_