Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: content/browser/download/download_resource_handler.h

Issue 8372034: Created an interface for DownloadFile, for use in unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up download file interface and unit test class. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_RESOURCE_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_RESOURCE_HANDLER_H_
6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_RESOURCE_HANDLER_H_ 6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_RESOURCE_HANDLER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/timer.h" 13 #include "base/timer.h"
14 #include "content/browser/download/download_file.h" 14 #include "content/browser/download/download_file.h"
15 #include "content/browser/download/download_id.h" 15 #include "content/browser/download/download_id.h"
16 #include "content/browser/download/download_types.h"
Randy Smith (Not in Mondays) 2011/11/10 21:58:43 I wouldn't think you'd need this include in both .
ahendrickson 2011/11/13 00:50:21 Need it in the header file, as we're declaring a D
16 #include "content/browser/renderer_host/global_request_id.h" 17 #include "content/browser/renderer_host/global_request_id.h"
17 #include "content/browser/renderer_host/resource_handler.h" 18 #include "content/browser/renderer_host/resource_handler.h"
18 19
19 class DownloadFileManager; 20 class DownloadFileManager;
20 class ResourceDispatcherHost; 21 class ResourceDispatcherHost;
21 22
22 namespace content { 23 namespace content {
23 class DownloadBuffer; 24 class DownloadBuffer;
24 } 25 }
25 26
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 base::TimeTicks download_start_time_; // used to collect stats. 108 base::TimeTicks download_start_time_; // used to collect stats.
108 base::TimeTicks last_read_time_; // used to collect stats. 109 base::TimeTicks last_read_time_; // used to collect stats.
109 size_t last_buffer_size_; // used to collect stats. 110 size_t last_buffer_size_; // used to collect stats.
110 static const int kReadBufSize = 32768; // bytes 111 static const int kReadBufSize = 32768; // bytes
111 static const int kThrottleTimeMs = 200; // milliseconds 112 static const int kThrottleTimeMs = 200; // milliseconds
112 113
113 DISALLOW_COPY_AND_ASSIGN(DownloadResourceHandler); 114 DISALLOW_COPY_AND_ASSIGN(DownloadResourceHandler);
114 }; 115 };
115 116
116 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_RESOURCE_HANDLER_H_ 117 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_RESOURCE_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698