Get printing working in Aura.

Get printing working in Aura.
Splits printing_context_cairo into gtk and no system dialog versions.  No system dialog versions are used in Chrome OS and Aura.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=13915
TEST=Build Chrome with Aura.  Hit ctrl-p from any web page.  Print preview page should come up and should be able to print via Cloud Print.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109059

[Scott Byer, 2011-11-03 22:22:35]

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_gt...
File printing/printing_context_gtk.cc (right):

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_gt...
printing/printing_context_gtk.cc:13: #include <gtk/gtk.h>
Since these are no longer guarded, the include order should be fixed - identity,
system, non-system.

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_no...
File printing/printing_context_no_system_dialog.cc (right):

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_no...
printing/printing_context_no_system_dialog.cc:13: #include <unicode/ulocdata.h>
Same here on include order - move between identity and non-system includes ('git
cl presubmit' should report these)

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_no...
printing/printing_context_no_system_dialog.cc:71:
printable_area_device_units.SetRect(0, 0, width, height);
Is this to fix a bug? This doesn't match the line from printing_context_cairo.cc

[Albert Bodenhamer, 2011-11-03 23:58:40]

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_gt...
File printing/printing_context_gtk.cc (right):

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_gt...
printing/printing_context_gtk.cc:13: #include <gtk/gtk.h>
On 2011/11/03 22:22:35, Scott Byer wrote:
> Since these are no longer guarded, the include order should be fixed -
identity,
> system, non-system.

Done.

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_no...
File printing/printing_context_no_system_dialog.cc (right):

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_no...
printing/printing_context_no_system_dialog.cc:13: #include <unicode/ulocdata.h>
On 2011/11/03 22:22:35, Scott Byer wrote:
> Same here on include order - move between identity and non-system includes
('git
> cl presubmit' should report these)

Done.

http://codereview.chromium.org/8372030/diff/3001/printing/printing_context_no...
printing/printing_context_no_system_dialog.cc:71:
printable_area_device_units.SetRect(0, 0, width, height);
As discussed, the original code was both dependent on gtk and arbitrary.  This
removes the dependency and simplifies the code.

On 2011/11/03 22:22:35, Scott Byer wrote:
> Is this to fix a bug? This doesn't match the line from
printing_context_cairo.cc

[Scott Byer, 2011-11-04 00:04:57]

lgtm

[abodenha, 2011-11-04 16:47:34]

On 2011/11/04 00:04:57, Scott Byer wrote:
> lgtm

Had to make some minor gyp changes to fix a build issue on Windows (it would
affect Mac too if anyone turns Aura on there)

Could you take another quick look at the .gyp?

[Scott Byer, 2011-11-04 17:02:19]

Looks good.

On 2011/11/04 16:47:34, abodenha wrote:
> On 2011/11/04 00:04:57, Scott Byer wrote:
> > lgtm
> 
> Had to make some minor gyp changes to fix a build issue on Windows (it would
> affect Mac too if anyone turns Aura on there)
> 
> Could you take another quick look at the .gyp?

[commit-bot: I haz the power, 2011-11-07 21:26:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8372030/20001

[commit-bot: I haz the power, 2011-11-07 23:33:21]

Try job failure for 8372030-20001 (retry) (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-08 16:50:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8372030/27001

[commit-bot: I haz the power, 2011-11-08 18:45:18]

Change committed as 109059