Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8372024: Enable "Open Link in New Window" in the context menu (Closed)

Created:
9 years, 2 months ago by rustema
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable "Open Link in New Window" in the context menu when IncognitoModeAvailability policy is set to FORCED. BUG=101092 TEST=Set IncognitoModeAvailability to FORCED. Open times.com. Right-click on some link. Now, "Open Link in New Window" menu item is available. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mattias Nissler (ping if slow)
I assume the window that opens is also incognito? If so, LGTM.
9 years, 2 months ago (2011-10-24 09:18:06 UTC) #1
rustema
On 2011/10/24 09:18:06, Mattias Nissler wrote: > I assume the window that opens is also ...
9 years, 2 months ago (2011-10-24 17:59:34 UTC) #2
rustema
9 years, 2 months ago (2011-10-24 17:59:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rustema@google.com/8372024/1
9 years, 2 months ago (2011-10-25 21:02:53 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 22:57:39 UTC) #5
Change committed as 107224

Powered by Google App Engine
This is Rietveld 408576698