Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 8372021: Move history extension API implementation to history dir. (Closed)

Created:
9 years, 2 months ago by Aaron Boodman
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move history extension API implementation to history dir. We're moving all the extension api implementations out of browser/extensions into the directory with the code they are automating. BUG=101244 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106968

Patch Set 1 #

Patch Set 2 : class rename #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -721 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_history_api.h View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/extensions/extension_history_api.cc View 1 chunk +0 lines, -382 lines 0 comments Download
D chrome/browser/extensions/extension_history_api_constants.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/extensions/extension_history_api_constants.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/extensions/extension_history_apitest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/history/history_extension_api.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/history/history_extension_api.cc View 1 14 chunks +62 lines, -39 lines 0 comments Download
A + chrome/browser/history/history_extension_apitest.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Aaron Boodman
Also move constants into history_extension_api.cc. The reason we originally needed to do this no longer ...
9 years, 2 months ago (2011-10-22 06:07:57 UTC) #1
Aaron Boodman
9 years, 2 months ago (2011-10-22 06:08:05 UTC) #2
brettw
lgtm
9 years, 2 months ago (2011-10-24 16:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8372021/2002
9 years, 2 months ago (2011-10-24 18:29:08 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/extensions/extension_function_dispatcher.cc. While running patch -p1 --forward --force; patching file chrome/browser/extensions/extension_function_dispatcher.cc ...
9 years, 2 months ago (2011-10-24 18:29:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/8372021/8001
9 years, 2 months ago (2011-10-24 18:58:43 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 20:29:13 UTC) #7
Change committed as 106968

Powered by Google App Engine
This is Rietveld 408576698