Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 8372020: Handle all enum members in the switch statement. (Closed)

Created:
9 years, 2 months ago by krasin1
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Handle all enum members in the switch statement. It simplifies the Native Client build which usually compiles source files with -Werror.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ppapi/cpp/var.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
krasin1
9 years, 2 months ago (2011-10-22 02:32:16 UTC) #1
brettw
lgtm
9 years, 2 months ago (2011-10-22 04:24:11 UTC) #2
krasin
Brett, I don't have a committer access to Chrome. Could you please make me a ...
9 years, 2 months ago (2011-10-22 04:25:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krasin@chromium.org/8372020/1
9 years, 2 months ago (2011-10-22 04:26:18 UTC) #4
brettw
I checked the commit checkbox. Hopefully this will just commit it.
9 years, 2 months ago (2011-10-22 04:26:38 UTC) #5
krasin
Thanks a lot! If CQ would fail, I will ask somebody on Monday (I didn't ...
9 years, 2 months ago (2011-10-22 04:28:26 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-22 07:37:48 UTC) #7
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 106848, job name
was 8372020-1 (retry) (retry) (retry) (retry).

Powered by Google App Engine
This is Rietveld 408576698