Issue 8372018: Fix two warnings surfaced by closure compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8372018: Fix two warnings surfaced by closure compiler. (Closed)

Created:
9 years, 2 months ago by eroman

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, mmenke

CC:
chromium-reviews, eroman, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/resources/net_internals/hsts_view.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/net_internals/log_util.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

mmenke

LGTM. Kinda odd that 'use strict' was fine with the hsts_view funkiness.

9 years, 2 months ago (2011-10-22 00:31:59 UTC) #2

eroman

Yeah. The scoping rules in javascript are really weird, I still dont quite understand what ...

9 years, 2 months ago (2011-10-22 00:47:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/8372018/1

9 years, 2 months ago (2011-10-22 00:47:57 UTC) #4

Change committed as 106838