Issue 8372001: aura: Make tab-dragging Escape code be cross-platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8372001: aura: Make tab-dragging Escape code be cross-platform. (Closed)

Created:
9 years, 2 months ago by Daniel Erat

Modified:
9 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura: Make tab-dragging Escape code be cross-platform. This gets rid of a noisy NOTIMPLEMENTED() in DraggedTabController::DidProcessEvent(). BUG=98345 TEST=manual: checked that escape aborts tab dragging in aura Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106990

Patch Set 1 #

Patch Set 2 : whoops, let's try not breaking gtk #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	chrome/browser/ui/views/tabs/dragged_tab_controller.cc	View	1	3 chunks	+5 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

On 2011/10/21 19:50:51, sky wrote: > Nice! Does the header need to be updated too? ...

9 years, 2 months ago (2011-10-21 23:16:59 UTC) #3

LGTM

Expand Messages | Collapse Messages