Issue 8371023: Calls to rph updating existing handlers are ignored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8371023: Calls to rph updating existing handlers are ignored. (Closed)

Created:
9 years, 2 months ago by benwells

Modified:
9 years, 2 months ago

Reviewers:
tony, commit-bot: I haz the power, koz (OOO until 15th September)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Calls to rph updating existing handlers are ignored. This happens when a handler is registered, where there is already a handler with the same origin and scheme already registered. These calls should go through the the registry and update the registered handler, and now do. This was broken recently however the unit tests did not catch the problem, because the key logic was in browser.cc. That logic has been moved into the registry and a test added. BUG=99926 TEST=Unit test added. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107052

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -9 lines)			Patch
M	chrome/browser/custom_handlers/protocol_handler_registry.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/custom_handlers/protocol_handler_registry.cc	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/8371023/1

9 years, 2 months ago (2011-10-25 00:38:53 UTC) #4

Change committed as 107052

Expand Messages | Collapse Messages