Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 8371008: Revert 106717 - Revert 106677 (caused several PPAPI test timeouts, see http://crbug.com/101154) (Closed)

Created:
9 years, 2 months ago by brettw
Modified:
9 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 106717 - Revert 106677 (caused several PPAPI test timeouts, see http://crbug.com/101154) - Remove the proxy callback tracker. This doesn't properly delete callbacks when the corresponding resource goes away. This can lead to leaks or crashes in the plugin when the callback is triggered unexpectedly. BUG=http://crbug.com/86279 Review URL: http://codereview.chromium.org/8226009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8364040 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -331 lines) Patch
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D ppapi/proxy/callback_tracker.h View 1 chunk +0 lines, -66 lines 0 comments Download
D ppapi/proxy/callback_tracker.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 2 chunks +1 line, -13 lines 0 comments Download
M ppapi/proxy/enter_proxy.h View 1 chunk +76 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/proxy/interface_proxy.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 chunk +9 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 9 chunks +27 lines, -21 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 2 chunks +25 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 5 chunks +129 lines, -43 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 4 chunks +17 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 7 chunks +45 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.h View 2 chunks +16 lines, -15 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.cc View 14 chunks +79 lines, -54 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 2 months ago (2011-10-21 19:49:13 UTC) #1
Nico
9 years, 2 months ago (2011-10-21 22:25:36 UTC) #2
lgtm

On Fri, Oct 21, 2011 at 12:49 PM,  <brettw@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Revert 106717 - Revert 106677 (caused several PPAPI test timeouts, see
> http://crbug.com/101154)
> - Remove the proxy callback tracker.
>
> This doesn't properly delete callbacks when the corresponding resource goes
> away. This can lead to leaks or crashes in the plugin when the callback is
> triggered unexpectedly.
>
> BUG=http://crbug.com/86279
>
> Review URL: http://codereview.chromium.org/8226009
>
> TBR=brettw@chromium.org
> Review URL: http://codereview.chromium.org/8364040
>
> TBR=thakis@chromium.org
>
> Please review this at http://codereview.chromium.org/8371008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     ppapi/ppapi_proxy.gypi
>  D     ppapi/proxy/callback_tracker.h
>  D     ppapi/proxy/callback_tracker.cc
>  M     ppapi/proxy/dispatcher.h
>  M     ppapi/proxy/dispatcher.cc
>  M     ppapi/proxy/enter_proxy.h
>  M     ppapi/proxy/interface_proxy.h
>  M     ppapi/proxy/interface_proxy.cc
>  M     ppapi/proxy/plugin_dispatcher.h
>  M     ppapi/proxy/plugin_dispatcher.cc
>  M     ppapi/proxy/ppapi_messages.h
>  M     ppapi/proxy/ppb_file_ref_proxy.h
>  M     ppapi/proxy/ppb_file_ref_proxy.cc
>  M     ppapi/proxy/ppb_instance_proxy.h
>  M     ppapi/proxy/ppb_instance_proxy.cc
>  M     ppapi/proxy/ppb_url_loader_proxy.h
>  M     ppapi/proxy/ppb_url_loader_proxy.cc
>  M     ppapi/thunk/ppb_instance_api.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698