Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 8370034: A build fix for Mac GCC. (Closed)

Created:
9 years, 2 months ago by Hironori Bono
Modified:
9 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

A build fix for Mac GCC. This is a build fix for Mac GCC caused by r106669 <http://crrev.com/106669>;. BUG=none TEST=fix builds on the "Webkit Mac (valgrind)" bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/base/file_stream_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
Greetings, Unfortunately, the "WebKit Mac (valgrind)" bot still uses Mac gcc and it has been ...
9 years, 2 months ago (2011-10-24 09:44:25 UTC) #1
willchan no longer on Chromium
9 years, 2 months ago (2011-10-24 15:36:10 UTC) #2
Lgtm

Sent from my iNexus.
On Oct 24, 2011 2:44 AM, <hbono@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> Greetings,
>
> Unfortunately, the "WebKit Mac (valgrind)" bot still uses Mac gcc and it
> has
> been failing for more than three days since r106669:
> <http://chromegw.corp.google.**com/i/chromium.memory.fyi/**
>
waterfall?show=Webkit%20Mac%**20(valgrind)<http://chromegw.corp.google.com/i/chromium.memory.fyi/waterfall?show=Webkit%20Mac%20(valgrind)>
> >.
> (I'm not sure if it is the right fix, though.)
>
> Regards,
>
> Hironori Bono
>
> Description:
> A build fix for Mac GCC.
> This is a build fix for Mac GCC caused by r106669 <http://crrev.com/106669
> >.
>
> BUG=none
> TEST=fix builds on the "Webkit Mac (valgrind)" bot.
>
> Please review this at
http://codereview.chromium.**org/8370034/<http://codereview.chromium.org/8370...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     net/base/file_stream_posix.cc
>
>
> Index: net/base/file_stream_posix.cc
> ==============================**==============================**=======
> --- net/base/file_stream_posix.cc       (revision 106893)
> +++ net/base/file_stream_posix.cc       (working copy)
> @@ -105,6 +105,8 @@
>   return res;
>  }
>
> +}  // namespace
> +
>  // Cancelable wrapper around a Closure.
>  class CancelableCallback {
>  public:
> @@ -126,8 +128,6 @@
>   const base::Closure callback_;
>  };
>
> -}  // namespace
> -
>  // FileStream::AsyncContext ------------------------------**
> ----------------
>
>  class FileStream::AsyncContext {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698