Issue 8370033: Add a 'hidden' parameter to RenderViewContextMenuProxy::UpdateMenuItem().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8370033: Add a 'hidden' parameter to RenderViewContextMenuProxy::UpdateMenuItem(). (Closed)

Created:
9 years, 2 months ago by Hironori Bono

Modified:
9 years, 2 months ago

Reviewers:
Avi (use Gerrit), Ben Goodger (Google)

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a 'hidden' parameter to RenderViewContextMenuProxy::UpdateMenuItem(). This change adds a 'hidden' parameter to RenderViewContextMenuProxy::UpdateMenuItem() so we can hide a context-menu item when the Spelling service does not return any suggestions. BUG=93746 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107091

Patch Set 1 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -2 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_gtk.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_gtk.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_mac.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_mac.mm	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/spelling_menu_observer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings, I would like to write a background of this change. Even though the current ...

9 years, 2 months ago (2011-10-24 10:28:36 UTC) #1

lgtm

Expand Messages | Collapse Messages